Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashed root domain to analytics events on web #6274

Closed
jleibs opened this issue May 9, 2024 · 0 comments
Closed

Add hashed root domain to analytics events on web #6274

jleibs opened this issue May 9, 2024 · 0 comments
Assignees
Labels
📊 analytics telemetry analytics 🕸️ web regarding running the viewer in a browser
Milestone

Comments

@jleibs
Copy link
Member

jleibs commented May 9, 2024

Now that we expect to be running Rerun on the web in more places it would be helpful to differentiate coarse distributions of web-users without leaking pii.

Proposal is to hash the root domain and include this in our analytics events.

Because our tracked user sessions are also per-domain, this will not let us track users cross-domain, just understand how many different domains we have and the relatively volumes / usage patterns representative of that domain.

@jleibs jleibs added 🕸️ web regarding running the viewer in a browser 📊 analytics telemetry analytics labels May 9, 2024
@jleibs jleibs added this to the 0.16 milestone May 9, 2024
@jleibs jleibs self-assigned this May 14, 2024
jleibs added a commit that referenced this issue May 14, 2024
### What
Resolves:
- #6274
- #6288

I added the processing at the last stage of the analytics output so we
don't depend on every code path possibily populating the analytics event
to do its own domain evaluation and/or hashing.

Validated events look correct in posthog:

![image](https://github.com/rerun-io/rerun/assets/3312232/17ddf585-5135-4ad1-8132-f64661b9e730)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6322?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6322?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6322)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@jleibs jleibs closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📊 analytics telemetry analytics 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

1 participant