Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the GitLab system tests #1020

Open
slarse opened this issue Mar 11, 2022 · 0 comments
Open

Refactor the GitLab system tests #1020

slarse opened this issue Mar 11, 2022 · 0 comments

Comments

@slarse
Copy link
Collaborator

slarse commented Mar 11, 2022

Currently, the GitLab system tests have two big warts.

  1. All of the tests exist in a single test module, which is quite large.
  2. For some reason, I decided that putting most asserts into a module separate from the tests was a good idea (it's not).

To address 1), the single module can be split according to the command categories (repos, issues, etc).

To address 2), the assertions can be brought back into the modules where they are relevant, and inlined into tests where appropriate. The _assert_on_projects helper could be made a public helper function as it's likely to be needed in every test module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant