Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azimuth correction for hemisphere is not clear from docstrings #9

Open
rabwent11 opened this issue Jun 3, 2020 · 0 comments
Open

Azimuth correction for hemisphere is not clear from docstrings #9

rabwent11 opened this issue Jun 3, 2020 · 0 comments

Comments

@rabwent11
Copy link

In pv.py >> def run_model(...) docstring:
"Azimuth angle (degrees, 180 = towards equator)".

In trigon.py >> aperture_irradiance(..) docstring:
"0 = towards pole, going clockwise, 3.14 = towards equator."

In trigon.py >> aperture_irradiance(..) lines 230-231, correction is made by rotating azimuth clockwise by pi if lat in southern hemisphere:

if coords[0] < 0:
    azimuth = azimuth + np.pi

Docstrings could be updated to say "Azimuth angle (degrees, 180 = South)" and "0 = towards North, going clockwise, 3.14 = towards South."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rabwent11