Should this be called from a config file for easier testing?

[kjaymiller]

    # TODO: Should this be called from a config file for easier testing?
    site_vars: dict = {
        "SITE_TITLE": "Untitled Site",
        "SITE_URL": "https://example.com", # TODO: #73 Make this http://localhost:8000
        }

https://github.com/kjaymiller/render_engine/blob/81971b54aca229bc1ee295909f2e874a40759e20/src/render_engine/site.py#L25-28

Currently the site_vars are hard-coded into the site.__init__() so if you pass in any site_vars, it overrides the default.

If these were separate, then you could partially update site_vars and then pass it into the site.__init__().

My suggestions is to store the vars in a config file, and then load them into the site.__init__() along with any manual site_vars (they could also load from config).

Currently thought is to use JSON as it most similar to dictionary which is what the site_vars are.

Future

• Allow multiple config options including json, cfg, yaml, and pyproject.toml

[kjaymiller]

• Create file to look for: (Default: RENDER_ENGINE.json)
• Values to look_for:

{
SITE_SETTINGS: {},
SITE_VARS: {},
PLUGINS: []
}

• site to have logic for from_config

[kjaymiller]

Working example of how to implement this pattern is:

# from https://github.com/kjaymiller/kjaymiller.com/blob/main/routes.py#L18C1-L21C33

from render-engine import Site
import json

app = Site()
with open("settings.json") as json_file:
    settings = json.loads(json_file.read())
app.site_vars.update(**settings)

[kjaymiller]

This would be syntactic sugar that, if documented correctly would automatically be applied when an application is created.