You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I still believe that it doesn't make sense to have this attribute that requires fields that are not included in collection (date).
There are a few options that I would lean on other devs for some opinion on.
Option 1: Leave the RSSFeed in the collection
It is an option.
Option 2: Add RSSFeed to blog
move all the methods and other things to Blog which does have the date field.
Option 3: Create a RSSFeed Class that can be passed into the collection that has a date field.
I like this as it makes a distinction that can be added to any collection but tells the collection that there is a date expected. It also means that we can do things like add checks for attributes, assign guids, etcs
Collections by default currently have Feeds. These feeds will be invalid if the collection is not a blog or customized with some date fields.
The feeds should be removed from the default collection.
render-engine/src/render_engine/collection.py
Lines 60 to 61 in e16e6ad
The text was updated successfully, but these errors were encountered: