Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Feed from default collection #287

Open
kjaymiller opened this issue Oct 22, 2023 · 1 comment
Open

Remove Feed from default collection #287

kjaymiller opened this issue Oct 22, 2023 · 1 comment
Milestone

Comments

@kjaymiller
Copy link
Collaborator

Collections by default currently have Feeds. These feeds will be invalid if the collection is not a blog or customized with some date fields.

The feeds should be removed from the default collection.

Feed: RSSFeed
feed_title: str

@kjaymiller
Copy link
Collaborator Author

More Thought on This:

I still believe that it doesn't make sense to have this attribute that requires fields that are not included in collection (date).

There are a few options that I would lean on other devs for some opinion on.

Option 1: Leave the RSSFeed in the collection

It is an option.

Option 2: Add RSSFeed to blog

move all the methods and other things to Blog which does have the date field.

Option 3: Create a RSSFeed Class that can be passed into the collection that has a date field.

I like this as it makes a distinction that can be added to any collection but tells the collection that there is a date expected. It also means that we can do things like add checks for attributes, assign guids, etcs

@kjaymiller kjaymiller added this to the Backlog milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant