-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass default template values for Page, Collection #236
Comments
More info: { The result when calling test.html will be "Test1" This change would have some values defined by default which would reduce the need to manually define your template all the time It would also make it so that if you use that object, you can rely on a default template path. If the system defines a default the user and theme maker both know what the default is and can always default their path to it. |
This is connected to #228 |
Okay, so we would be adding those attributes to the
The end goal would be that if a template path is provided for, say, Would we then control the loaders from the |
Yes one of the things that running |
I'm a little torn on this as I'm trying to figure out if it's better to ask the user to specify. Assumption:
WHY THIS ASSUMPTION IS BAD:
Also currently with render_content the check is (in order): Finally if none of those things exist... I think it may be better to instruct users with good documentation and error handling how to ensure that their pages load as expected. |
There is only a few default template paths to be expected (explicit is better than...)
Some themes probably have a desired usage and forcing the user to memorize each one (especially when there are multiple themes being used).
Suggestion
ThemeManager
could have attributes for-
default_page_template
,-
default_collection_template
,-
default_archive_template
Each of these would be
str|None
and only apply if the attribute is suppliedThe text was updated successfully, but these errors were encountered: