Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_content hookspec is not applied if calling the page.content directly outside of site.render or site.render_collection #198

Open
kjaymiller opened this issue Jun 3, 2023 · 0 comments
Milestone

Comments

@kjaymiller
Copy link
Collaborator

As of v 2023.6.1 - The render_content hookspec is now called on parsed content. This means that you are modifying the rendered html and not the pre-existing content. This ensures that plugin developers don't need to think about the content's base type and instead can focus on the ensured HTML-formatted string.

That also means that if you are calling the content elsewhere then you are not getting the plugin's changes but the base-rendered content.

@kjaymiller kjaymiller changed the title render_content hookspec is not applied if calling the page.content directly outside of site.render or site.render_collection render_content hookspec is not applied if calling the page.content directly outside of site.render or site.render_collection Dec 14, 2023
@kjaymiller kjaymiller added this to the Backlog milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant