should parse_content and parse_content_path also accept an optional Page object

[kjaymiller]

Currently in the BasePageParser, parse_content and parse_content_path both only take a single input (for no particular reason).

Currently only parser_extras is only used in BasePageParser.parse.

This is fine but with an idea of a filter extra this is best if applied as early as possible to reduce.

For Example:

from render_engine import Site, Collection, Page
from render_engine_json import JSONPageParser

site = Site()

def filter_by(data): # this should always only accept just the one attribute data
     return [x for x in data if x['name'].startswith("B")

data = [
{"name": "Foo"},
{"name": "Bar"}
{"name": "Biz"}
]

@site.page
class TestPage(Page):
    Parser = JSONPageParser
    parser_extras = {'filter': filterer}

site.render()

Filtering doesn't happen until page.Parser.parse is called so data as stored has the filtered out values. If you referenced the values before and after that page was rendered, you would get different values.

Potential solutions

Option 1

Add the Page attribute to be available in parse_content and parse_content_path. This would ensure that the only data that is present is the same, but it wouldn't preserve the original data (which you could potentially still call manually)

Option 2

Save the data in a new attribute

If I had to choose between the two I would choose option-1. But perhaps I'm missing an option.