Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about limitation with provide/inject while using portal #16

Closed
renatodeleao opened this issue Apr 20, 2020 · 3 comments · Fixed by #67
Closed

Add note about limitation with provide/inject while using portal #16

renatodeleao opened this issue Apr 20, 2020 · 3 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@renatodeleao
Copy link
Owner

A know limitation of portal-vue so while this depends on it we should warn users.

Gladely vue 3 new <Teleport /> won't have these issues

Related
@renatodeleao renatodeleao added the enhancement New feature or request label Apr 20, 2020
@LinusBorg
Copy link

LinusBorg commented May 18, 2020 •
edited

This limitation of my portal-vue lib was one of the reasons that I later created https://github.com/LinusBorg/vue-simple-portal

It's aimed precisely at the use case of components that only need to be moved ot the bottom of the <body> element's children and doesn't have the limitation concerning inject and $parent.

So maybe give it a try. As a bonus, it's much lighter than portal-vue. And closer to how the native teleport in Vue 3 works.

@renatodeleao
Copy link
Owner Author

@LinusBorg thanks for stopping by, it's not everyday that you have core vue members around!

I must admit that I was not aware of that "lite" version, i'll make sure to give it a spin, and include a reference in the docs as a suggestion for people who might be using provide/inject with this component.

Not sure if you seen it, but I was actually thinking about making this component portal-agnostic #11: although I strongly suggest and recommend using a portal implementation for dialogs (particularly yours), i'm thinking about not including portal-vue as an explicit dependency since this should allegedly work with all portal-vue versions (including that simple one) and any other portal implementations (not that i'm aware of any other actual alternative to portal-vue to be honest, but devs like to have their own things), so your comment gives an extra push to that idea.

Lastly many thanks for portal-vue been using it almost since my day one in vueland.
Cheers!

@LinusBorg
Copy link

Sound like a good plan.

And thanks for the kind words :)

@renatodeleao renatodeleao mentioned this issue Jul 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[v0.8.0] - housekeeping renatodeleao/a11y-vue-dialog
2 participants
@LinusBorg @renatodeleao