Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delphi.build() assume numeric "delphi" version in options object #42

Open
deltics opened this issue Nov 2, 2013 · 0 comments
Open

Delphi.build() assume numeric "delphi" version in options object #42

deltics opened this issue Nov 2, 2013 · 0 comments

Comments

@deltics
Copy link
Contributor

deltics commented Nov 2, 2013

The check for Delphi version later than 7 fails if an "XE" version identifier is using in the options object due to this test:

Int32.parse(lVer) > 7

deltics added a commit to deltics/train that referenced this issue Nov 2, 2013
 - symbolic constants for Delphi versions (internal, numeric versions)

 - DelphiVersion() method to map "delphi" options flag to DELPHI_XXX version

 - DelphiVersionName() method to provide human meaningful name of DELPHI_XXX version number

 - build() method modified to use DelphiVersion() and DelphiVersionName() to support non-numeric delphi version in options object (e.g. "XE", "XE2" etc)
deltics added a commit to deltics/train that referenced this issue Nov 2, 2013
…sion ("XE", "XE2" etc)

 - symbolic constants added for Delphi versions (internal, numeric versions)

 - DelphiVersion() method to map "delphi" options flag to DELPHI_XXX version

 - DelphiVersionName() method to provide human meaningful name of DELPHI_XXX version number
carlokok added a commit that referenced this issue Dec 5, 2013
Fix for Issue #42 (non-numeric "delphi" version in build options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant