You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the new or updated feature that you are suggesting?
I think it would be beneficial in the long run to rename this adapter to @remix-run/aws-lambda to avoid confusion.
Remove the peer dependency on @architect/architect since it is not used
Why should this feature be included?
The @remix-run/architect adapter is actually a generic adapter for AWS Lambda behind API Gateway. This package can be used as the adapter for projects using AWS CDK, AWS SAM, and serverless framework in addition to architect (and lambda without a framework).
Currently, the architect adapter has no need for a peer dependency of architect because it is not used within the package.
I think this will avoid confusion moving forward for people who want to run Remix within AWS Lambda but are using another framework to work with the service.
This discussion was converted from issue #1038 on August 02, 2022 14:17.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
What is the new or updated feature that you are suggesting?
@remix-run/aws-lambda
to avoid confusion.@architect/architect
since it is not usedWhy should this feature be included?
@remix-run/architect
adapter is actually a generic adapter for AWS Lambda behind API Gateway. This package can be used as the adapter for projects using AWS CDK, AWS SAM, and serverless framework in addition to architect (and lambda without a framework).I think this will avoid confusion moving forward for people who want to run Remix within AWS Lambda but are using another framework to work with the service.
Beta Was this translation helpful? Give feedback.
All reactions