Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible security issue: //TARGET_URL/ results in 302 to target #72

Open
craigsc opened this issue Jul 25, 2023 · 1 comment · May be fixed by #73
Open

Possible security issue: //TARGET_URL/ results in 302 to target #72

craigsc opened this issue Jul 25, 2023 · 1 comment · May be fixed by #73

Comments

@craigsc
Copy link

craigsc commented Jul 25, 2023

Example: https://reactrouter.com//google.com/
Expectation: 404
Actual: 302 redirects to google.com

This is bad because a malicious actor can send links that look like official reactrouter.com pages but the end users get silently redirected to a possible malicious site owned by the sender

I haven't dug too much into this yet but also see that it affects the main remix.run site too - https://remix.run//google.com/
@mcansh
Copy link
Collaborator

mcansh commented Jul 26, 2023 •
edited

one solution is to redirect using an absolute url with the origin instead of using just the pathname

- throw redirect(url.pathname.slice(0, -1) + url.search);
+ throw redirect(url.origin + url.pathname.slice(0, -1) + url.search);

https://github.com/remix-run/react-router-website/blob/main/app/modules/http-utils/remove-slashes.ts

mcansh added a commit that referenced this issue Jul 26, 2023
@mcansh
fix(removeTrailingSlashes): include origin when redirecting
4e0c63b 
closes #72

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh linked a pull request Jul 26, 2023 that will close this issue
Open
mcansh added a commit that referenced this issue Jul 26, 2023
@mcansh
fix(removeTrailingSlashes): include origin when redirecting
179b4d5 
closes #72

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(removeTrailingSlashes): include origin when redirecting remix-run/react-router-website
2 participants
@craigsc @mcansh