New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material UI Errors in React Toolbar Components #1901
Comments
Hello. Any progress on this issue? page: https://70ehsh-3000.preview.csb.app/ (open console in browser, and reload page. warnings should be present) |
Same issue here |
I just submitted the above PR which implements the proposal referenced by @JanReichelt . This fix also makes tooltips work for inactive buttons (which is the typical behavior seen in most apps). |
Summary
The React Toolbar Component (e.g. the CommandButton) throws Errors, because a disabled Button is wrapped with a Tooltip (see screenshot), which directly disables it (because pointer events are prohibited this way).
I experienced it with the prebuilt react undo and redo buttons, but it should apply to all other Toolbar buttons as well.
Versions
(used in the example repo)
Steps to reproduce
Just use the 5 Minute Tutorial boilerplate and add a MarkdownToolbar from
@remirror/react
. Or:Example Git-Repo: https://github.com/JanReichelt/remirror-mui-error
Inspect the browser console to see the mentioned errors.
Possible Solution
It is proposed here that the Button could be wrapped in an intermediary html tag to re-enable pointer events as a quick fix.
Screenshot(s)
The text was updated successfully, but these errors were encountered: