Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You get disconnected from emp run when a lot of output is generated #1120

Open
sumeet opened this issue Feb 13, 2018 · 2 comments
Open

You get disconnected from emp run when a lot of output is generated #1120

sumeet opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels

Comments

@sumeet
Copy link
Contributor

sumeet commented Feb 13, 2018

The remote connection will die with an error message like this:

attaching to container (e413a2f40b7de61f84839a7b8fd0d52f3b25997f80afcf3c7c2eee6eea2af305): InvalidParameterException: Upload too large: 1049218 bytes exceeds limit of 1048576
                               status code: 400, request id: ed318bff-1116-11e8-beegoku :: ~/remind/r101-api ‹16b3fe1› »

Reproducible if running commands with a lot of output, or smth likewhile true ; do ; find / ; done. It's a bit jarring to have the session suddenly die. You've gotta log back in and get back into the interactive context you were in, and be really careful about the output you're generating. And if you mess up and generate too much output, you have to do it again.

Is there any way empire can be more resilient to running commands with a lot of output remotely?

@ejholmes
Copy link
Contributor

ejholmes commented Feb 14, 2018

To clarify the issue above, this can happen when Empire is configured to forward logs from attached containers to CloudWatch. There's a lot of ways that CloudWatch logs forwarding can fail (throttling, messages too big, stream too big, etc).

When we originally discussed implementing this, we agreed that failing closed would be best for security, so containers would die if logs couldn't be forwarded. I can see how that would get annoying pretty quickly in the case above.

We could potentially provide a boot flag to ensure that CloudWatch logs failures don't effect the session, which would be pretty easy to do.

@ejholmes ejholmes self-assigned this Feb 14, 2018
@ejholmes ejholmes added the bug label Feb 27, 2018
@sumeet
Copy link
Contributor Author

sumeet commented Apr 26, 2018

just had this happen to me again :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants