Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Typescript nightlies #655

Open
cjquines opened this issue Apr 26, 2024 · 2 comments
Open

Test against Typescript nightlies #655

cjquines opened this issue Apr 26, 2024 · 2 comments
Labels
github_actions Pull requests that update GitHub Actions code typing Something type related

Comments

@cjquines
Copy link
Collaborator

cjquines commented Apr 26, 2024

We should maybe start typechecking against the Typescript nightlies, or at least the betas, so we can get early signals; I know that type-fest does this for example.

Anyway, the only breaking change for us is regex checking, which helpfully informs us that the u regex flag is only available when targeting es6 or later. Should we just remove it in master?

@cjquines cjquines added the typing Something type related label Apr 26, 2024
@eranhirsch
Copy link
Collaborator

We probably won't officially support Typescript 5.5 in V1, and in V2 we compile with target ES2022. Would that allow us to avoid handling anything for typescript 5.5?

Let's create a separate issue (or use this one) for your suggestion on testing against nightly.

@cjquines
Copy link
Collaborator Author

yep, v2 is clean against 5.5. i'll edit this issue for testing against nightly

@cjquines cjquines changed the title Breaking changes in Typescript 5.5 Test against Typescript nightlies Apr 26, 2024
@cjquines cjquines added the github_actions Pull requests that update GitHub Actions code label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code typing Something type related
Projects
None yet
Development

No branches or pull requests

2 participants