Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamedArtifact should default on the base model itself #79

Open
paulletang opened this issue Sep 10, 2021 · 0 comments
Open

NamedArtifact should default on the base model itself #79

paulletang opened this issue Sep 10, 2021 · 0 comments
Labels
breaking change This change requires a major version bump. enhancement New feature or request size/L

Comments

@paulletang
Copy link
Contributor

Description

Instead of requiring us to use FillRequiredProperties on the inheriting models, we should just default a randomly generated name on the base model.
If this is undesirable for any of the models that inherit from this, they're probably not a typical NamedArtifact, and might need to stop inheriting from that.

Example

Instead of defaulting on FillRequiredProperties, we would default on the NamedArtifact itself.

Desired Behavior

Name is autogenerated if not defined when instantiated.

Current Behavior

Name is null until FillRequiredProperties, which sometimes happens in the API repository, or sometimes not at all!

Why this enhancement would be useful to most Relativity.Testing.Framework users

Consistent and predictable autogeneration of the name property on NamedArtifacts.
We should also continue this paradigm with other stories to include everything that can be defaulted without looking up values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change requires a major version bump. enhancement New feature or request size/L
Projects
None yet
Development

No branches or pull requests

1 participant