Async method without await

[abilson]

In CreateWorkspace.cs line 32 the method definition is marked async, however, there is no await call in the method body.

This would be a quick fix to add the await keyword, however, the async call on line 77 returns an object, ProcessOperationResult, which returns a compiler error when using the await keyword,

'ProcessOperationResult' does not contain a definition for 'GetAwaiter'

This may indicate a defect, not in this source code, but in the API call not being properly async:

proxy.Repositories.Workspace.CreateAsync(templateArtifactID, workspaceDTO);

[abilson]

After further investigation, I've discovered that the API call, although async in nature, is not architected in an async manner I'm familiar with. While the workspace does appear to be created in a separate thread, in order for our code to remain async we must subscribe to the proxy's event listeners. The definition of this method ought not to be async since we are blocking the execution to wait for the ProcessState to return Completed.

For more information about the documented use of the CreateAsync method, please see Creating Workspaces and Monitoring Asynchronous Processes