Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document or remove string truncation #92

Open
Arithmomaniac opened this issue May 29, 2018 · 2 comments
Open

Document or remove string truncation #92

Arithmomaniac opened this issue May 29, 2018 · 2 comments
Labels
discussion
Projects
Issue Prioritization

Comments

@Arithmomaniac
Copy link
Collaborator

  • Are we sure we want to truncate strings instead of throwing an exception?
    • If so, we should probably have documentation.
  • Why have any cutoff for a max-length string?

https://github.com/tsdservices/Gravity/blob/75584f9558f46b94ce91e12c3829be34b9c6b717/Gravity/Gravity/Base/BaseDto.cs#L113-L125
@mrobustelli mrobustelli added this to Prioritized in Issue Prioritization Sep 24, 2018
@KalinaTSD
Copy link
Collaborator

It's not necessary to cutoff anything. This is something minor. I'm going to fix it.

@Arithmomaniac
Copy link
Collaborator Author

Arithmomaniac commented Apr 29, 2019 •
edited

It's not necessary to cutoff anything.

What do you plan on doing when a very long string is matched to a fixed-length field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
Issue Prioritization
  
Prioritized
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arithmomaniac @KalinaTSD