Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or change signature of UpdateField #44

Open
Arithmomaniac opened this issue Mar 2, 2018 · 0 comments
Open

Remove or change signature of UpdateField #44

Arithmomaniac opened this issue Mar 2, 2018 · 0 comments

Comments

@Arithmomaniac
Copy link
Collaborator

https://github.com/tsdservices/Gravity/blob/075de8e177e33c903227f00bf58863484e59649e/Gravity/Gravity/DAL/RSAPI/RsapiDao.Update.cs#L104-L105

The code in this method is hard to understand, and the rules for mapping values to RDO values do not follow the same ones as in ToHydratedDto.

More broadly, what is this code trying to solve? We have mapping code elsewhere. If it's because sometimes you want to just set a single field, then either we should implement #25, or just add a params at the end of UpdateRelativityObject and related methods that lets you specify which fields you want to update, like seen here.

At a bare minimum, we should use the same basic mapping logic we use in ToHydratedDto, even if that requires the end user to specify the field type along with the GUID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue Prioritization
  
Prioritized
Development

No branches or pull requests

1 participant