Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rsapi Unit tests are not properly using VerifyAll #142

Open
Arithmomaniac opened this issue Sep 21, 2018 · 2 comments · Fixed by #143
Open

Rsapi Unit tests are not properly using VerifyAll #142

Arithmomaniac opened this issue Sep 21, 2018 · 2 comments · Fixed by #143
Assignees

Comments

@Arithmomaniac
Copy link
Collaborator

Our provider tests are supposed to call mockProvider.VerifyAll after every test. But the code to do so is decorated with a SetUp attribute instead of a TearDown attribute, which never fires. Here is an example:

[SetUp]
public void End()
{
//ensure any defined methods called
mockProvider.VerifyAll();
}

Flipping this value shows that 10 tests are not written to meet the verification criterion:

image

In the process of fixing this, we should create a base unit test class to handle the mockProvider setup and verification.

@Arithmomaniac
Copy link
Collaborator Author

#143 was not a fix; it was just a related dead-code removal.

@Arithmomaniac Arithmomaniac reopened this Sep 26, 2018
@Arithmomaniac
Copy link
Collaborator Author

@aarongilbert123 Assigning it to you was a suggestion; if you don't want it, unassign yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants