Assertion error version 1.19.0

[darijasavina]

We are calculating some vrp problems with vrp-cli, sometimes they are quite big. In version 1.19.0 we have bug, that sometimes appears, and sometimes doesn't even on the same problem. We tried debugging vrp-cli code and realised that problem happens in file feature_combinator:: line 122, on assertions.
It's hard to understand your code with our level of rust knowledge. Can you check please? We can help fixing the problem, but we need some help from your side.

Error file: vrp_core:: construction::enablers::feature_combinator::accept_solution_state_with_states

vrp_cli_error.zip

[reinterpretcat]

In 1.19.0 I did a big architectural change and introduced a feature concept. Features can be combined and this requires some extra change in the logic which responsible to catch dependencies between different features. In short, previously the code [1] was executed only once, now it might be executed more times: once for each combined feature and once from the top. I suspect this might cause some troubles in your case.

However, as your problem seems to be big, it might be related to assertion itself: maybe try to increase the number of allowed cycles [2]. However, if the issue is not reproducible on old versions, most likely it is a bug which requires some investigation.

https://github.com/reinterpretcat/vrp/blob/master/vrp-core/src/construction/enablers/feature_combinator.rs#L117-L148
https://github.com/reinterpretcat/vrp/blob/master/vrp-core/src/construction/enablers/feature_combinator.rs#L122

[darijasavina]

In 1.19.0 I did a big architectural change and introduced a feature concept. Features can be combined and this requires some extra change in the logic which responsible to catch dependencies between different features. In short, previously the code [1] was executed only once, now it might be executed more times: once for each combined feature and once from the top. I suspect this might cause some troubles in your case.

However, as your problem seems to be big, it might be related to assertion itself: maybe try to increase the number of allowed cycles [2]. However, if the issue is not reproducible on old versions, most likely it is a bug which requires some investigation.

https://github.com/reinterpretcat/vrp/blob/master/vrp-core/src/construction/enablers/feature_combinator.rs#L117-L148 https://github.com/reinterpretcat/vrp/blob/master/vrp-core/src/construction/enablers/feature_combinator.rs#L122

Thank you for the answer!

I increased the number of allowed cycles to 1000 and it helped. I couldn't catch the problem during at least 20 launches.
I also tried using version 1.18.4 and couldn't reproduce the issue.