Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new preset estimators, metrics, and cv iterators #15

Open
reiinakano opened this issue May 30, 2017 · 5 comments
Open

Add new preset estimators, metrics, and cv iterators #15

reiinakano opened this issue May 30, 2017 · 5 comments

Comments

@reiinakano
Copy link
Owner

reiinakano commented May 30, 2017

Sklearn has a TON of estimators, metrics, and cv iterators that could trivially be added to the xcessiv.presets package. I'm a bit focused on other issues to bother adding them all.

Anyone who can help add to the list can easily do so.

Adding preset estimators/metrics/cvs is very easy. There's literally no need to understand how the rest of Xcessiv works, just take a look and copy the patterns in the xcessiv.presets package. Also, add corresponding relevant tests for your addition.

Please keep PR's limited to one feature addition only for easy debugging and reformatting if needed. Of course, you can submit as many PR's as you like :)

@reiinakano reiinakano changed the title Add new preset estimators and metrics Add new preset estimators, metrics, and cv iterators May 30, 2017
@techscientist
Copy link

@reiinakano Hey, I just wanted to say that this is an AWESOME library! I'm currently a Kaggle novice, so this library is great! Also, I might be able to work on this later, so I'll send you a pull request once I've made some updates. Thanks!

@reiinakano
Copy link
Owner Author

reiinakano commented May 30, 2017

@techscientist thank you for your kind feedback!

I would love PRs. Thank you!

@enisnazif
Copy link
Contributor

Am also interested on working on this, I'll start soon :)

@robertmartin8
Copy link

At some stage I would like to contribute with this, but as I am new, I would like to clarify what you mean by

add corresponding relevant tests for your addition

What would be the scope of such tests?

@reiinakano
Copy link
Owner Author

You can just copy the style of existing tests for each one that you add :) it's probably simpler than adding the preset code itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants