Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Zoltar upload action to use new validations code #4667

Open
5 tasks
ydhuang28 opened this issue Aug 29, 2021 · 1 comment
Open
5 tasks

Switch Zoltar upload action to use new validations code #4667

ydhuang28 opened this issue Aug 29, 2021 · 1 comment
Assignees

Comments

@ydhuang28
Copy link
Contributor

Issue

Currently, the Zoltar upload action uses old validations code. The action runs travis/upload_zoltar_master.sh, and in this shell script travis/validate-data.sh is run as a step. However, travis/validate-data.sh actually uses the validations code directly in code/validation/test_formatting.py, and not the corresponding new code.

Steps

  • Add covid19-forecast-hub-validations as a submodule in the hub
  • Modify Zoltar upload action
    • Add a step to explicitly clone the new validations submodule (regular git clone does not deep clone, i.e., recursively clone submodules)
    • Modify travis/validate-data.sh to use code in submodule
  • Test functionality
@ydhuang28 ydhuang28 self-assigned this Aug 29, 2021
@ydhuang28 ydhuang28 added data-validation enhancement New feature or request labels Aug 29, 2021
@ydhuang28 ydhuang28 removed their assignment Oct 21, 2021
@matthewcornell
Copy link
Member

Per this Slack discussion, we are removing the misc_scripts directory. Attached are the three files in it, which may be useful for solving this issue.

misc_scripts.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants