Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding a min engine version was a breaking change #103

Open
zburke opened this issue Aug 29, 2023 · 1 comment
Open

adding a min engine version was a breaking change #103

zburke opened this issue Aug 29, 2023 · 1 comment

Comments

@zburke
Copy link

zburke commented Aug 29, 2023

e38a412 added a new build requirement and therefore constitutes a breaking change. Anybody using Node.JS < 18 with a ^2.0.0 or ~2.4.0 dependency on this library faces a build failure without making any changes in their code.

The change itself is fine, but it belongs in a new major version, not a patch release. Please consider reverting the change and publishing v2.4.6, then reapplying the change after bumping the version to v3.0.0.
@zburke zburke changed the title min supported engine change is a breaking change but published in a patch release adding a min engine version was a breaking change Aug 29, 2023
@MikeTaylor
Copy link

👍

@zburke zburke mentioned this issue Aug 31, 2023
Merged
11 tasks
@zburke zburke mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zburke @MikeTaylor