Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep both image transformation methods (local + cloudinary) #89

Open
LER0ever opened this issue Sep 27, 2020 · 3 comments
Open

Keep both image transformation methods (local + cloudinary) #89

LER0ever opened this issue Sep 27, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@LER0ever
Copy link

Hi @arshad ,

Recently the image transformation in gatsby-theme-library switched from local to cloudinary, and I was wondering if we could keep both of them.

I do understand that some people might benefit from using Cloudinary as it provides faster transformations, and great CDN support.

However, for my use case, I would prefer doing that locally, since

  • I use Gatsby Cloud for website building, which includes awesome build caching features, so that image transformation usually takes no time, unless I make changes to images.
  • Cloudinary free plan has this quota / credit thing, and I don't yet have a Cloudinary account

Currently, in order to get local transformations, I would need to manually revert that specific commit, namely git revert -m 1 7bad86e1a5b1bf743792aaa6b6454c9eeb743ba3. But that's certainly not future-proof.

@shadcn
Copy link
Contributor

shadcn commented Sep 27, 2020

Oh definitely. I built gatsby-theme-library primarily for reflexjs.org (I assumed no one else was using this).

I’m going to add support for both local and cloudinary.

@shadcn shadcn self-assigned this Sep 27, 2020
@shadcn shadcn added the enhancement New feature or request label Sep 27, 2020
@shadcn
Copy link
Contributor

shadcn commented Oct 5, 2020

@LER0ever is this a blocker for you? I don't think I'll be able to get to this before next week.

@LER0ever
Copy link
Author

LER0ever commented Oct 6, 2020

@arshad that's ok. I'm currently using an older version of Reflex, and a modified version of gatsby-theme-library to showcase code snippets. So please take your time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants