Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional blocks broken for version checks under ghcjs #549

Open
alexfmpe opened this issue Oct 24, 2019 · 1 comment
Open

Conditional blocks broken for version checks under ghcjs #549

alexfmpe opened this issue Oct 24, 2019 · 1 comment

Comments

@alexfmpe
Copy link
Member

alexfmpe commented Oct 24, 2019

Checkout alexfmpe/reflex-project-skeleton@c841533 and run ./reproduce-bug

It seems this conditional isn't being processed properly when under ghcjs.
I managed to build by cloning singleton-bool locally and changing

-if impl(ghc >=7.8)
+if impl(ghc >=7.8) || impl(ghcjs >=7.8) 

I have cabal2nix 2.1.4 on my environment and it seems to handle all cases properly, as long as the compiler version is also passed in. That is,
cabal2nix --compiler ghcjs-8.6 --shell . > shell.nix yields the expected output but
cabal2nix --compiler ghcjs --shell . > shell.nix does not.

@alexfmpe alexfmpe changed the title Conditional blocks broken for version check under ghcjs Conditional blocks broken for version checks under ghcjs Oct 24, 2019
@alexfmpe
Copy link
Member Author

Still present in latest reflex-platform develop.
Oddly this only happens when there is an override in the project, even though the cabal version is always 0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants