feat(auth-pages): allow translation for required input field messages #5868
Conversation
🦋 Changeset detectedLatest commit: e4d8ad5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…eat/Allow-translation-for-required-field-messages
Ac-Srikanth
changed the title
There was a problem hiding this comment.
Hey @Ac-Srikanth thank you for the PR! We'll review it soon. Before we do, can you please check Creating a changeset section in our contributing guide? We'll need a changeset for the related changes 💯
…eat/Allow-translation-for-required-field-messages
|
Hey @Ac-Srikanth thank you for the update! I was reviewing the PR and just noticed that we also require a small update on our live previews package to reflect i18n changes; Can you provide the keys you've created to the files below:
We've marked this PR to be included in our May release and I'm hoping to complete its review if you can provide the changes I mentioned above 🙏 |
|
hey @aliemir thank you for the review , i have updated the keys to these files as well. |
…ttps://github.com/Ac-Srikanth/refine into feat/Allow-translation-for-required-field-messages
aliemir
changed the title
…ttps://github.com/Ac-Srikanth/refine into feat/Allow-translation-for-required-field-messages
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behaviour?
Auth Input fields which were required had no custom error message feature.
What is the new behaviour?
can provide Custom error message for required Auth Input fields with correct translation.
fixes # (issue)
#5855
Notes for reviewers
This is my first PR , please do suggest changes or more things to be added if i missed out any.