Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI]: No warning shows up if an unknown command is supplied #377

Closed
jamesgeorge007 opened this issue Apr 1, 2020 · 5 comments
Closed

Comments

@jamesgeorge007
Copy link
Contributor

Leverage the strict() method as part of yargs API to handle unknown commands.

@thedavidprice
Copy link
Contributor

Hi @jamesgeorge007 Thanks for jumping in on this. Our Yargs handling needs a lot of TLC. Would you be able to spend a bit more time with me to 1) outline our desired constraints and error handling and 2) implement from there?

This is effectively a duplicate of PR #136 Please read that thread for background context. Also, Ben Coe is a friend and core contributor on Yargs who’s offered to help answer questions and give direction. Anytime!

In?

@jamesgeorge007
Copy link
Contributor Author

Yeah sure 👍

@thedavidprice
Copy link
Contributor

thedavidprice commented Apr 13, 2020

@jamesgeorge007 Apologies for dropping the ball on communication here. At the time of this discussion, Peter had attempted to add .strict() to our commands — we thought it was working but then realized it broke a few commands (e.g. yarn rw g …) where we have multiple options.

All previous and current work + history is here: #136

I’m going to cc you now so you’ll be included on the thread. Also, I’m writing up a comment to Ben Coe with the current issues. If you have any yargs implementation experience, please feel free to dive in!

Closing this out to move over to the PR.

@jamesgeorge007
Copy link
Contributor Author

@thedavidprice I'm heavily caught up at the moment, regardless I would love to lend a helping hand as I find time.

@thedavidprice
Copy link
Contributor

@jamesgeorge007 All good an understood! We'll be here when you're time frees up -- and looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants