Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Add Logger check to CI #2160

Closed
thedavidprice opened this issue Mar 31, 2021 · 2 comments · Fixed by #2798
Closed

E2E: Add Logger check to CI #2160

thedavidprice opened this issue Mar 31, 2021 · 2 comments · Fixed by #2798

Comments

@thedavidprice
Copy link
Contributor

related to #1886

@dthyresson Can you suggest a basic Logger functionality check (or checks) we could include in the Cypress tests? It likely needs to be file or path-based as we spin up the dev server in a separate process than Cypress, which means I'm not sure if Cypress has access to the console (I can verify).

We can make code modifications, which is probably an ideal Cypress use case if applicable.

@dthyresson
Copy link
Contributor

@thedavidprice I have not used Cypress before, but I think we would:

  • update logger.ts in api-side to use a file as a destination to a tmp directory (probably similar to that I use in CI tests)
  • update the blog post service to import the logger and do a few trace, info, debugs
  • check that log file has some expected content

@dthyresson
Copy link
Contributor

Chatted with @thedavidprice and @dac09 and will add 04-api Cypress integration to test logger.

@dthyresson dthyresson added this to To do in Logging via automation Apr 6, 2021
@dthyresson dthyresson moved this from To do to v1.0 in Logging Apr 6, 2021
@jtoar jtoar added this to Backlog in Current-Release-Sprint May 21, 2021
@jtoar jtoar removed the v1/priority label Jun 1, 2021
@jtoar jtoar removed this from v1.0 in Logging Jun 8, 2021
@jtoar jtoar moved this from Backlog to In progress (priority) in Current-Release-Sprint Jun 8, 2021
@thedavidprice thedavidprice moved this from In progress (priority) to On deck (future release) in Current-Release-Sprint Jun 9, 2021
@thedavidprice thedavidprice added this to the future-release milestone Jun 9, 2021
@dthyresson dthyresson moved this from On deck (future-release; help-wanted) to In progress (priority) in Current-Release-Sprint Jun 10, 2021
@thedavidprice thedavidprice moved this from In progress (priority) to Ready to merge in Current-Release-Sprint Jun 10, 2021
Current-Release-Sprint automation moved this from Ready to merge to Done Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants