Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E Integration tests to CI #1658

Closed
thedavidprice opened this issue Jan 19, 2021 · 3 comments
Closed

Add E2E Integration tests to CI #1658

thedavidprice opened this issue Jan 19, 2021 · 3 comments
Projects
Milestone

Comments

@thedavidprice
Copy link
Contributor

dependent on #1637

Ideally, the CI (via GitHub actions) will do the following:

  • Trigger on PR merge (note: also possible to use PR Packages and therefore trigger each PR update, although I'm not sure this is necessary)
  • Using the published canary versions, including the canary for create-redwood-app package, run our Cypress test script (here, with files in e2e/ directory). Instructions can be found in Contributing.md
  • To figure out --> how to message/notify on success or failure? If this is run outside the PR, where will the alerts show up?
@thedavidprice thedavidprice added this to the v1.0 milestone Jan 19, 2021
@thedavidprice thedavidprice added this to To do in Core via automation Jan 19, 2021
@Tobbe
Copy link
Member

Tobbe commented Jan 19, 2021

  • Trigger on PR merge (note: also possible to use PR Packages and therefore trigger each PR update, although I'm not sure this is necessary)

I came here from #1637 to suggest exactly this, but of course you had already thought about it 🙂 I think it's worth it, running on PR updates. Should help ensure we have a stable main branch. Not saying it has been a problem so far, but it will help it stay that way going forward. Would also help with your last point, by blocking merge on failing tests.

@thedavidprice
Copy link
Contributor Author

We'll just chalk it up to "great minds think alike", right? 😆

Totally game to try on PR updates/commits and see how it works!

@thedavidprice
Copy link
Contributor Author

Closing in favor of #1886

Core automation moved this from To do to Done Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Core
  
Done
Development

No branches or pull requests

3 participants