Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken HTTPS on https://reactjs.org #2616

Closed
mickeyreiss-visor opened this issue Sep 19, 2017 · 3 comments
Closed

Broken HTTPS on https://reactjs.org #2616

mickeyreiss-visor opened this issue Sep 19, 2017 · 3 comments

Comments

@mickeyreiss-visor
Copy link

mickeyreiss-visor commented Sep 19, 2017

I'm currently seeing an security certificate error on https://redux.js.org in Google Chrome Version 60.0.3112.113.

image
image
image
image

(edit: incorrect url)

@timdorr
Copy link
Member

timdorr commented Sep 19, 2017

The docs site doesn't work in HTTPS. It's hosted by GitHub, so they don't have a cert for js.org.

@timdorr timdorr closed this as completed Sep 19, 2017
@indus
Copy link

indus commented Nov 6, 2017

@timdorr JS.ORG is using Cloudflare and they provide "Universal SSL" - so it is easily possible to get HTTPS.

Back then when the "redux" subdomain was added to JS.ORG, SSL support was an opt-in. But you didn't took the option. Now it is the default, but owners of "old" subdomains have to make a PR to change it.
The reason for so little enforcement is that pages may show mixed-content warnings if e. g. paths to CSS where set absolute or other non-HTTPS content was included.
So switching would be easy but it has to be triggered by you. Just file a PR that removes the comment in that line

I'm writing to you because @jlebensold asked me on twitter why you don't have HTTPS

@timdorr
Copy link
Member

timdorr commented Nov 6, 2017

Hmm, looks like we also need to update that URL, since the rackt org (since disbanded) has been typosquated. Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants