Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Manifest V3 #1037

Open
Tracked by #1012
timdorr opened this issue Jan 19, 2022 · 2 comments · May be fixed by #1247
Open
Tracked by #1012

Upgrade to Manifest V3 #1037

timdorr opened this issue Jan 19, 2022 · 2 comments · May be fixed by #1247

Comments

@timdorr
Copy link
Member

timdorr commented Jan 19, 2022

https://developer.chrome.com/docs/extensions/mv3/intro/mv3-migration/

While there are a lot of controversies around the new manifest format, I don't believe most affect us. The advantages are getting ahead of enforcement later (we've got a year until V2 extensions stop working) and getting into a faster approval workflow for updates on the Web Store.

Probably the most consequential is the move from background pages to service workers. Since we maintain a store on the background page, that logic will need to be persisted. We can probably get fancy and wrap some of the ways we access that store to lazy load it from storage (window.store -> getStore()). Here are the docs on migrating to SWs: https://developer.chrome.com/docs/extensions/mv3/migrating_to_service_workers/

I don't think there's much else that affects us. Some minor things around actions changes, but that's mostly just moving stuff around in the manifest.json.

Edit: Pinning this since it's got a deadline associated with it. We'll have to take this seriously.

@timdorr timdorr pinned this issue Jan 19, 2022
@respectYourNeighbour
Copy link

I also get some warning regarding this:

  • Permission 'notifications' is unknown or URL pattern is malformed.
  • Permission 'contextMenus' is unknown or URL pattern is malformed.

@Methuselah96
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants