Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is broken and inconsistent now that the projects have split #45

Open
tmc opened this issue Jul 22, 2016 · 9 comments
Open
Assignees

Comments

@tmc
Copy link

tmc commented Jul 22, 2016

https://github.com/redux-autoform/redux-autoform/blob/master/docs-md/documentation.md references https://gearz-lab.github.io/redux-autoform/blob/master/src/MaterialUiComponentFactoryHelper.js

@JonatanSalas
Copy link
Member

@tmc I will take a look, this was a bad mine when performing one refactor! Thank you!

@andrerpena
Copy link
Member

andrerpena commented Jul 22, 2016

@JonatanSalas I was going to fix it but I couldn't even find it.

@JonatanSalas
Copy link
Member

JonatanSalas commented Jul 22, 2016

In field section of documentation:

"The list of possible values for type depends on which component is registered in the ComponentFactory. That is, foo is a valid value for type, as long as the ComponentFactory registered a component for foo. The list of valid types for the DefaultEditComponentFactory can be found here. size | The size of the component, in grid units. Values can range from 1 to 12. component | Which component to use. If no component is set, the default one will be used."

We have to edit all urls in documentation because they point to gearz-lab organization

@andrerpena andrerpena changed the title documentation.md broken link Documentation is broken and inconsistent now that the projects have split Jul 27, 2016
@andrerpena andrerpena self-assigned this Jul 27, 2016
@andrerpena
Copy link
Member

This is my priority now. Once the house is clean again, I'll move to adding features.

andrerpena added a commit that referenced this issue Jul 27, 2016
andrerpena added a commit that referenced this issue Jul 27, 2016
@andrerpena
Copy link
Member

andrerpena commented Jul 27, 2016

I got good progress today on the Bootsrap project's documentation: https://github.com/redux-autoform/redux-autoform-bootstrap-ui

Now I'm focusing on making this one better.

EDIT: I wrongfully pointed to my own fork which is not updated.

@JonatanSalas
Copy link
Member

@andrerpena how it's this going?

@andrerpena
Copy link
Member

andrerpena commented Aug 2, 2016

@JonatanSalas I just fixed #56 and #61 . Now I should be able to return to this one.

@JonatanSalas
Copy link
Member

Really good job! :)

andrerpena added a commit that referenced this issue Aug 4, 2016
andrerpena added a commit that referenced this issue Aug 4, 2016
andrerpena added a commit that referenced this issue Aug 4, 2016
@andrerpena
Copy link
Member

The documentation is at least organized for now. There are just some components missing. Also the tabs introduced by @JonatanSalas . I'll come back to this and close it when I'm done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants