Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete configuration structure #143

Open
Rykath opened this issue Jul 16, 2021 · 0 comments
Open

incomplete configuration structure #143

Rykath opened this issue Jul 16, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@Rykath
Copy link
Collaborator

Rykath commented Jul 16, 2021

PR #142 introduced a new configuration structure using classes, but in practice the objects are converted to dictionaries in the end.
A reevaluation of the new structure might also reveal further room for improvement.

Incomplete:

  • accessing the configuration is done mostly using config['key'] and not config.key
  • config.variables contains a dictionary generated from Variables and not the objects themselves (in main the objects are used again)
  • the new classes use to_dict (or similar) instead of implementing the necessary methods for a MutableMapping (see docs, especially .items())

Possible improvements (time will tell):

  • central defaults file vs defaults near the implementation
  • a system default.yaml file which is read before profit.yaml
  • config classes in a central file vs near the implementation
@Rykath Rykath added the enhancement New feature or request label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant