Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/beakerlib/Tuned-takes-too-long-to-reload-start-when-ulimit/runtest.sh should be more clear #544

Open
RHEmployee opened this issue Aug 3, 2023 · 3 comments

Comments

@RHEmployee
Copy link
Contributor

Test checks if there is delay after tuned start.

It exploits small time window among beakerlib commands which is not clear at first look.

Maybe just add sleep .5 and more comments will help.
Or maybe use timeout command in combination with exploit of "race condition".

@yarda
Copy link
Contributor

yarda commented Aug 3, 2023

Yep, I think you should use the timeout command or similar mechanism. Now you are only checking that the 'sysctl' log message was removed, which IMHO was.

@RHEmployee
Copy link
Contributor Author

Bug has been revealed in test here:
#421 (comment)

@RHEmployee
Copy link
Contributor Author

Proposed fix:
#545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants