Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-hosted-pipeline tests should not ignore missing bundle #4276

Open
clobrano opened this issue Mar 27, 2024 · 2 comments
Open

community-hosted-pipeline tests should not ignore missing bundle #4276

clobrano opened this issue Mar 27, 2024 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@clobrano
Copy link
Contributor

If the submitted operator bundle has the wrong structure (e.g. the bundle folder inside operator-name/x.y.z/, like we did by mistake in #4199) the tests ignore the lack of bundle or catalog and terminates with success

[set-github-pr-title : set-github-status] + TITLE=
[set-github-pr-title : set-github-status] + echo 'Setting the PR title'
[set-github-pr-title : set-github-status] Setting the PR title
[set-github-pr-title : set-github-status] No bundles nor catalogs have been added/updated
[set-github-pr-title : set-github-status] + [[ '' != '' ]]
[set-github-pr-title : set-github-status] + [[ '' != '' ]]
[set-github-pr-title : set-github-status] + [[ '' != '' ]]
[set-github-pr-title : set-github-status] + echo 'No bundles nor catalogs have been added/updated'
[set-github-pr-title : set-github-status] + exit 0

full log: https://gist.github.com/rh-operator-bundle-bot/6e5f4598ee34371a84a11709b7aa0b58

I think not finding the bundle should result in an error instead.

@mporrato
Copy link
Collaborator

mporrato commented Apr 19, 2024

The behaviour of skipping the rest of the ci pipeline if there is no new bundle in the PR is by design. However the PR should not be automatically merged in this situation.

Thanks for reporting the issue: we will address discuss it.

Edit: Upon further thinking, automerge is still the right thing to do here: there are legitimate changes a maintainer can do outside of a bundle (for example updating the ci.yaml file or a readme file for the operator) that should be allowed to leverage the auto-merge feature.
The automatic merge for a situation like the PR you mentioned, even if it's not what the contributor intended, still does not prevent an additional fixup PR from being submitted and successfully processed.

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants