Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from rollup to vite #65

Closed
benoitf opened this issue Feb 29, 2024 · 3 comments · Fixed by #147
Closed

switch from rollup to vite #65

benoitf opened this issue Feb 29, 2024 · 3 comments · Fixed by #147
Assignees

Comments

@benoitf
Copy link
Collaborator

benoitf commented Feb 29, 2024

I think we got issues in the past with rollup (with 3rd party dependencies)

we switched extensions to use vite in Podman Desktop, probably this one should be converted as well.

@dgolovin dgolovin self-assigned this Feb 29, 2024
@dgolovin dgolovin added this to the 0.0.2 milestone Feb 29, 2024
@dgolovin
Copy link
Collaborator

Related to #38, due to rollup image plugin not being able to handle image import.

@dgolovin
Copy link
Collaborator

dgolovin commented Mar 1, 2024

Tried to switch but whatever I do I always got an error about window module resolution and I could not get past it. I am using the same config for vite from other extensions and the extension built with it fails to load after installation.

@dgolovin dgolovin modified the milestones: 0.0.2, 1.0.0 Mar 7, 2024
@nichjones1 nichjones1 removed this from the 1.0.0 milestone Mar 20, 2024
@dgolovin
Copy link
Collaborator

After migrating to vite the openid-client prints out message below

Error: Algorithm "sha256"  not supported. supported values: sha1, md5, passthrough
console.<computed> @ VM5:2
(anonymous) @ VM5:2
emit @ VM4 sandbox_bundle:2
onMessage @ VM4 sandbox_bundle:2

Using suggested plugins to bring back 'sha256' digest did not help.

I sent PR above, that addresses only build speed issue and leaves rollup intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants