Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance PR check for really checking code #55

Closed
benoitf opened this issue Feb 16, 2024 · 2 comments · Fixed by #146
Closed

Enhance PR check for really checking code #55

benoitf opened this issue Feb 16, 2024 · 2 comments · Fixed by #146
Assignees
@dgolovin
Labels
area/technical debt

Comments

@benoitf
Copy link
Collaborator

benoitf commented Feb 16, 2024

PR check is just building the extension but it does not check that the typescript is valid or run any unit tests or linter, etc so you can easily break anything
@dgolovin dgolovin self-assigned this Feb 20, 2024
@slemeur slemeur added this to the 1.0.0 milestone Feb 28, 2024
@odockal
Copy link
Contributor

odockal commented Feb 28, 2024

It would be nice to practically reuse what podman-desktop repo utilize.
Just hints what to add: sonar, dependabot (I have not really check if it is there?)

This was referenced Mar 19, 2024
Merged
Closed
@nichjones1 nichjones1 removed this from the 1.0.0 milestone Mar 20, 2024
@dgolovin dgolovin mentioned this issue Apr 8, 2024
Merged
@odockal
Copy link
Contributor

odockal commented Apr 16, 2024

We should also enable unit tests on PR check and other workflows.

@dgolovin dgolovin mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgolovin dgolovin

Labels
area/technical debt
Projects
None yet
Milestone
No milestone
5 participants
@benoitf @dgolovin @slemeur @odockal @nichjones1