Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append command name to workspace/executeCommand trace #284

Open
fbricon opened this issue May 7, 2024 · 2 comments
Open

Append command name to workspace/executeCommand trace #284

fbricon opened this issue May 7, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fbricon
Copy link
Contributor

fbricon commented May 7, 2024

It'd be convenient to directly see which command is executed on workspace/executeCommand, without having to set verbose trace and open specific message item
Screenshot 2024-05-07 at 16 17 57

I'd like to see this instead:

[Trace - 16:14:46] Sending request 'workspace/executeCommand [gopls.reset_go_mod_diagnostics] - (62)'.
Params: {
  "command": "gopls.reset_go_mod_diagnostics",
  "arguments": [
    {
      "URI": "file:///Users/fbricon/Dev/souk/IdeaProjects/lsp4ij-tests/untitled/src/go.mod",
      "DiagnosticSource": ""
    }
  ]
}


[Trace - 16:14:46] Received response 'workspace/executeCommand [gopls.reset_go_mod_diagnostics] - (62)' in 2ms.
No result returned.
@fbricon fbricon added enhancement New feature or request good first issue Good for newcomers labels May 7, 2024
@angelozerr
Copy link
Contributor

The trace follows the same format than vscode, so before doing that it should be nice that vscode change that too.

@fbricon
Copy link
Contributor Author

fbricon commented May 7, 2024

no we don't have to wait for them if it's an improvement. We have collapsible traces they don't have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants