Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove DISABLE_DEX environment variable from bundle manifests #364

Closed
wants to merge 8 commits into from
Closed

fix: Remove DISABLE_DEX environment variable from bundle manifests #364

wants to merge 8 commits into from

Conversation

wanderboessenkool
Copy link

@wanderboessenkool wanderboessenkool commented Aug 23, 2022 •
edited

What type of PR is this?
/kind bug

What does this PR do / why we need it:

Fixes bug #362

Have you updated the necessary documentation?

The documentation is already okay

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #362
The clusterserviceversion manifests set the DISABLE_DEX: false environment variable on the gitops-operator-controller-manager deployment, causing a torrent of DeprecationNotice events without a timestamp.

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

Hi @wanderboessenkool. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wanderboessenkool
fix: Remove DISABLE_DEX environment variable from bundle manifests
69483d1 
- Remove DISABLE_DEX environment variable from the
  gitops-operator-controller-manager manifest in the
  clusterserviceversion manifest.
- Fixes redhat-developer#362

Signed-off-by: Wander Boessenkool <wander.boessenkool@hcs-company.com>
@wanderboessenkool wanderboessenkool force-pushed the bugfix/remove_DSIABLE_DEX_from_csv branch from 33382e2 to 69483d1 Compare August 23, 2022 13:41
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign iam-veeramalla for approval by writing /assign @iam-veeramalla in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbose78 sbose78 Awaiting requested review from sbose78

@wtam2018 wtam2018 Awaiting requested review from wtam2018

Assignees
No one assigned
Labels
needs-ok-to-test needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitOps Operator 1.6 spams DISABLE_DEX deprecation events
2 participants
@wanderboessenkool @openshift-merge-robot