Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kas-installer: size parameter seemingly ignored #1594

Open
k-wall opened this issue Jun 10, 2022 · 3 comments
Open

Kas-installer: size parameter seemingly ignored #1594

k-wall opened this issue Jun 10, 2022 · 3 comments

Comments

@k-wall
Copy link

k-wall commented Jun 10, 2022

Testing the 0.44 alpha, using kas-installler (fleet-manager registered_users_per_organisation config configured with max_allowed_instances 2).

rhoas kafka create --bypass-checks --provider aws  --name penguin --size=x2

is accepted, but an x1 results.

{
  "browser_url": "http://localhost:8080/cahjsobprem07ts5qlog/dashboard",
  "cloud_provider": "aws",
  "created_at": "2022-06-10T12:51:45.301121744Z",
  "egress_throughput_per_sec": "100Mi",
  "href": "/api/kafkas_mgmt/v1/kafkas/cahjsobprem07ts5qlog",
  "id": "cahjsobprem07ts5qlog",
  "ingress_throughput_per_sec": "50Mi",
  "instance_type": "standard",
  "instance_type_name": "Standard",
  "kafka_storage_size": "1000Gi",
  "kind": "Kafka",
  "max_connection_attempts_per_sec": 100,
  "max_data_retention_period": "P14D",
  "max_partitions": 1500,
  "multi_az": true,
  "name": "penguin",
  "owner": "kwall_mk-bin-packing",
  "reauthentication_enabled": true,
  "region": "us-east-1",
  "size_id": "x1",
  "status": "accepted",
  "total_max_connections": 3000,
  "updated_at": "2022-06-10T12:51:45.301121744Z"
}

Originally posted by @k-wall in #1592 (comment)

@wtrocki wtrocki changed the title thank you @wtrocki - that works, but whilst I can create size x1 successfully, if I chose size x2, the system creates an x1. I'll raise a separate issue. Kas-installer target doesn't accept other sizes. Jun 10, 2022
@wtrocki
Copy link
Collaborator

wtrocki commented Jun 10, 2022

@k-wall - I'm really sorry for issues that you have been experiencing. I think generally we need to introduce kas-installer as valid target for the CLI and UI and pick right architecture to avoid billing. Initially that wasn't a bit problem in CLI as it was only about terms and conditions. Now we would have dozens of flags for billing, sizes that strongly depend on AMS.

I will investigate why this is happening and make fix asap

@wtrocki
Copy link
Collaborator

wtrocki commented Jun 10, 2022

Done quick check and I think this is quite tricky to do as in backend we mix both instance type and size value. instance types cannot be passed by users thus we need AMS for it.

plan developer.x1 or standard.x2 is being sent to backend. So if we do not have AMS information about what type of instance we want:

  • developer
  • standard
  • standard marketplace

We cannot really effectively send plan value to backend.

CC @pb82 - maybe we could chat about this next week.

@wtrocki
Copy link
Collaborator

wtrocki commented Jun 10, 2022

I think we need discussion in the team how we can support kas-installer without ams.
First idea in mind would be to have number of extra flags only for kas-installer that will provide missing ams info

@k-wall k-wall changed the title Kas-installer target doesn't accept other sizes. Kas-installer: size parameter seemingly ignored Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants