Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Knative v0.4 #42

Closed
kameshsampath opened this issue Mar 6, 2019 · 10 comments · Fixed by #43 or #116
Closed

Upgrade to Knative v0.4 #42

kameshsampath opened this issue Mar 6, 2019 · 10 comments · Fixed by #43 or #116
Labels
priority/high The issue or enhancement having highest priority

Comments

@kameshsampath
Copy link
Contributor

Upgrade the Knative installation to use v0.4

kameshsampath added a commit to kameshsampath/knative-tutorial that referenced this issue Mar 7, 2019
- added new module to demonstrate pollEnrich EIP with
- organized redundant instructions into partials
- upgraded instructions to setup Knative v0.4.0

fixes redhat-developer-demos#42, redhat-developer-demos#35
@kameshsampath kameshsampath reopened this Mar 22, 2019
@kameshsampath kameshsampath added the priority/high The issue or enhancement having highest priority label Mar 22, 2019
@kameshsampath
Copy link
Contributor Author

As the upgrade v.0.4.0 has lot of breaking changes, it better to have all functionalities throughly checked

@kameshsampath
Copy link
Contributor Author

@burrsutter - please add anything that you want to check specifically

@kameshsampath kameshsampath added this to the Knative v0.4.0 Upgrade milestone Mar 22, 2019
@bbrowning
Copy link

cc @lberk - based on some Slack discussions it sounds like you may be looking at both this tutorial and 0.4 in the near future :)

@kameshsampath
Copy link
Contributor Author

@lberk - thanks

@lberk
Copy link
Contributor

lberk commented Mar 27, 2019

@bbrowning @kameshsampath Please see PR77 for some fixes to help get the tutorial working on 0.4.0

@rhuss
Copy link

rhuss commented Mar 28, 2019

One issue I have with 0.4.0 is that the revision names are not predictable. I.e. its not greeter-0001 as used in the tutorial but a random suffix, which you can't easily predict in advance and added to the service's revisions array.

I think this part of the tutorial talking about 'pinned revisions' needs serious rework for 0.4.0 as there is no static revision which you can pre-add in deployment descriptor.

@lberk
Copy link
Contributor

lberk commented Mar 28, 2019

@rhuss strategies for this was discussed earlier today, one option is changing the tutorial so that we properly use the randomly generated revision names. @syedriko also mentioned using generation number (annotations I think?) might be a solution

@bbrowning
Copy link

You can get the latest created revision for any Knative Service with a kubectl command like:

kubectl get ksvc my-knative-service -o jsonpath="{.status.latestCreatedRevisionName}"

The tutorial will need to be changed to lookup this latest revision name and do a substitution in the yaml stored in the tutorial repo before applying it.

@rhuss
Copy link

rhuss commented Apr 5, 2019

@kamesh you could introduce a shell function like

function latest_revision() {
   local name=${1}
   local revision=$(kubectl get ksvc $name -o jsonpath="{.status.latestCreatedRevisionName}")
   echo "${name}-${revision}"
}

and then use it like in

kubectl get $(latest_revision my-knative-service)

You get the idea.

@kameshsampath
Copy link
Contributor Author

@rhuss we fixed this by querying revisions directly with labels and sort by creation stamp ( thanks to @markusthoemmes @bbrowning ) . I have added them to the tutorial. you should see them in next release.

kameshsampath added a commit to kameshsampath/knative-tutorial that referenced this issue Apr 5, 2019
- added copy to clipboard to setup
- added copy to clipboard to basics
- added copy to clipboard to configs and routes
- added copy to clipboard to scaling
- added copy to clipboard to build
- added copy to clipboard to eventing
- made quarkus as default
- fixes for revision pinning and traffic distribution
- tutorial namespace made as asciidoc attribute
- replaced yq with sed
- fixed template names

Fixes  redhat-developer-demos#42, redhat-developer-demos#85, redhat-developer-demos#66, redhat-developer-demos#115

Fixes redhat-developer-demos#42, redhat-developer-demos#85, redhat-developer-demos#66

(fix): Add clip to copy to build chapters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high The issue or enhancement having highest priority
Projects
None yet
4 participants