-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Knative v0.4 #42
Comments
- added new module to demonstrate pollEnrich EIP with - organized redundant instructions into partials - upgraded instructions to setup Knative v0.4.0 fixes redhat-developer-demos#42, redhat-developer-demos#35
As the upgrade v.0.4.0 has lot of breaking changes, it better to have all functionalities throughly checked |
@burrsutter - please add anything that you want to check specifically |
cc @lberk - based on some Slack discussions it sounds like you may be looking at both this tutorial and 0.4 in the near future :) |
@lberk - thanks |
@bbrowning @kameshsampath Please see PR77 for some fixes to help get the tutorial working on 0.4.0 |
One issue I have with 0.4.0 is that the revision names are not predictable. I.e. its not I think this part of the tutorial talking about 'pinned revisions' needs serious rework for 0.4.0 as there is no static revision which you can pre-add in deployment descriptor. |
You can get the latest created revision for any Knative Service with a kubectl command like: kubectl get ksvc my-knative-service -o jsonpath="{.status.latestCreatedRevisionName}" The tutorial will need to be changed to lookup this latest revision name and do a substitution in the yaml stored in the tutorial repo before applying it. |
@kamesh you could introduce a shell function like function latest_revision() {
local name=${1}
local revision=$(kubectl get ksvc $name -o jsonpath="{.status.latestCreatedRevisionName}")
echo "${name}-${revision}"
} and then use it like in kubectl get $(latest_revision my-knative-service) You get the idea. |
@rhuss we fixed this by querying revisions directly with labels and sort by creation stamp ( thanks to @markusthoemmes @bbrowning ) . I have added them to the tutorial. you should see them in next release. |
- added copy to clipboard to setup - added copy to clipboard to basics - added copy to clipboard to configs and routes - added copy to clipboard to scaling - added copy to clipboard to build - added copy to clipboard to eventing - made quarkus as default - fixes for revision pinning and traffic distribution - tutorial namespace made as asciidoc attribute - replaced yq with sed - fixed template names Fixes redhat-developer-demos#42, redhat-developer-demos#85, redhat-developer-demos#66, redhat-developer-demos#115 Fixes redhat-developer-demos#42, redhat-developer-demos#85, redhat-developer-demos#66 (fix): Add clip to copy to build chapters
Upgrade the Knative installation to use v0.4
The text was updated successfully, but these errors were encountered: