Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding instruction on registry repo #26

Closed
kameshsampath opened this issue Mar 4, 2019 · 1 comment
Closed

Adding instruction on registry repo #26

kameshsampath opened this issue Mar 4, 2019 · 1 comment
Assignees
@kameshsampath
Labels
bug Something isn't working

Comments

@kameshsampath
Copy link
Contributor

The command in build section currently says

jsonnet --ext-str contextDir='java/springboot' \
  --ext-str image='docker.io/demo/event-greeter:0.0.1' \
   docker-build.jsonnet\
    | yq r - | tee ../docker-build.yaml

need to add a note saying change demo to something that corresponds to the users container registry repository.
@kameshsampath kameshsampath added invalid This doesn't seem right bug Something isn't working and removed invalid This doesn't seem right labels Mar 4, 2019
@kameshsampath kameshsampath self-assigned this Mar 4, 2019
kameshsampath added a commit to kameshsampath/knative-tutorial that referenced this issue Mar 4, 2019
@kameshsampath
fix: Hello -> Namaste
647446c 
- Fixes the new revision deployments to use better noticeable change in the response message
- Adds note in build section about the container repository name

Fixes: redhat-developer-demos#25 redhat-developer-demos#26
@kameshsampath kameshsampath mentioned this issue Mar 4, 2019
Merged
@kameshsampath
Copy link
Contributor Author

@burrsutter closed this via #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kameshsampath kameshsampath

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kameshsampath