Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello -> Bonjour #25

Closed
burrsutter opened this issue Mar 3, 2019 · 1 comment
Closed

Hello -> Bonjour #25

burrsutter opened this issue Mar 3, 2019 · 1 comment
Assignees
@kameshsampath
Labels
enhancement New feature or request

Comments

@burrsutter
Copy link
Contributor

Describe the bug
Lets change Hello to Bonjour or Namaste, https://github.com/redhat-developer-demos/knative-tutorial/blob/master/01-basics/knative/service-env.yaml#L14
As that would make it much more obvious to the reader. Right now "Hi" to "Hello" is too subtle and easy for the audience to miss the point.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@kameshsampath
Copy link
Contributor

thanks @burrsutter will have it fixed in next iteration.

@kameshsampath kameshsampath self-assigned this Mar 4, 2019
@kameshsampath kameshsampath added the enhancement New feature or request label Mar 4, 2019
kameshsampath added a commit to kameshsampath/knative-tutorial that referenced this issue Mar 4, 2019
@kameshsampath
fix: Hello -> Namaste
647446c 
- Fixes the new revision deployments to use better noticeable change in the response message
- Adds note in build section about the container repository name

Fixes: redhat-developer-demos#25 redhat-developer-demos#26
@kameshsampath kameshsampath mentioned this issue Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kameshsampath kameshsampath

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burrsutter @kameshsampath