Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: WIP: Refactor load test #1163

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Conversation

jhutar
Copy link
Contributor

@jhutar jhutar commented May 14, 2024

Description

Refactor load test

Issue ticket number and link

KONFLUX-2570 - Divide loadTests.go file to a few separate files to reduce complexity
KONFLUX-2603 - load-test support for multi-platform-test repo templating to create branches
KONFLUX-2495 - Also measure signing speed
KONFLUX-2085 - simple scenario: refactor load test to handle repos with multiple components
KONFLUX-2086 - simple scenario: refactor load test to allow multiple apps and components and wait time

Type of change

Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Locally for now, will use CI to test

@openshift-ci openshift-ci bot requested review from ascerra and kasemAlem May 14, 2024 09:23
@jhutar jhutar changed the title WIP: Refactor load test refactor: Refactor load test May 16, 2024
@jhutar jhutar changed the title refactor: Refactor load test refactor: WIP: Refactor load test May 16, 2024
@jhutar
Copy link
Contributor Author

jhutar commented May 16, 2024

/retest

@jhutar jhutar force-pushed the fix24 branch 3 times, most recently from ada580a to 4341cdb Compare May 21, 2024 07:12
tests/load-tests/pkg/logging/time_and_log.go Fixed Show fixed Hide fixed

// Load 'users.json' into a slice of User structs
func LoadStageUsers(filePath string) ([]User, error) {
jsonData, err := os.ReadFile(filePath)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
tests/load-tests/pkg/logging/time_and_log.go Fixed Show fixed Hide fixed
tests/load-tests/pkg/options/options.go Fixed Show fixed Hide fixed

// Append slice to a CSV file
func writeToCSV(outfile string, batch [][]string) error {
file, err := os.OpenFile(outfile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0600)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign flacatus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jhutar added 29 commits June 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants