Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a make target to build-bundle with custom source build image #1162

Merged
merged 3 commits into from
May 22, 2024

Conversation

tisutisu
Copy link
Contributor

Description

adds a make target to build-bundle with source build image and update build-pipeline-selector in test namespace

Issue ticket number and link

part of story: https://issues.redhat.com/browse/STONEBLD-2353

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from jkopriva and tkdchen May 14, 2024 07:00
@tisutisu tisutisu changed the title feat: add a make target to build-bundle with source build image feat: add a make target to build-bundle with custom source build image May 14, 2024
tests/build/build_templates.go Outdated Show resolved Hide resolved
pkg/constants/constants.go Show resolved Hide resolved
tests/build/build_templates.go Show resolved Hide resolved
tests/build/build_templates.go Outdated Show resolved Hide resolved
tests/build/build_templates.go Show resolved Hide resolved
magefiles/magefile.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tkdchen
Copy link
Contributor

tkdchen commented May 22, 2024

/lgtm
/approve

@jinqi7
Copy link
Contributor

jinqi7 commented May 22, 2024

/approve

Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, jinqi7, tkdchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tisutisu tisutisu merged commit f2d50a5 into konflux-ci:main May 22, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants