Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RELEASE-230): update release service ref to konflux ci org #1144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

happybhati
Copy link
Contributor

This commit updates the release-service reference
as result of migration to konflux-ci from redhat-appstudio
more details parent EPIC:
https://issues.redhat.com/browse/RHTAPREL-800

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented May 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dheerajodha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

go.mod Outdated
@@ -41,7 +41,7 @@ require (
github.com/redhat-appstudio/image-controller v0.0.0-20231003082540-48893226ba8b
github.com/redhat-appstudio/integration-service v0.0.0-20231025084434-b3f521c408d1
github.com/redhat-appstudio/jvm-build-service v0.0.0-20240126122210-0e2ee7e2e5b0
github.com/redhat-appstudio/release-service v0.0.0-20240126184040-c1b86f4617e1
github.com/konflux-ci/release-service v0.0.0-20240126184040-c1b86f4617e1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the version changes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am trying to find the correct version. Hope it will be available once we merge the release-service PR

Once available it will appear in this pkg search https://pkg.go.dev/search?q=konflux-ci&m=package

@happybhati happybhati requested a review from jinqi7 May 7, 2024 06:59
@happybhati happybhati force-pushed the release-230 branch 3 times, most recently from b23aa0c to f0a62a0 Compare May 7, 2024 20:23
@happybhati
Copy link
Contributor Author

The dependency update requires the go version to be 1.21. @jinqi7 is taking a look.

note: module requires Go 1.21

@jinqi7
Copy link
Contributor

jinqi7 commented May 9, 2024

The dependency update requires the go version to be 1.21. @jinqi7 is taking a look.

note: module requires Go 1.21

I tried with go 1.21. But there are some conflicts between the new version of release-service and devfile library. It perhaps need to communicate with has team.

github.com/devfile/library/v2/pkg/devfile/generator
/home/admin/go1.21/gopath/pkg/mod/github.com/devfile/library/v2@v2.2.1-0.20230418160146-e75481b7eebd/pkg/devfile/generator/utils.go:600:14: cannot use corev1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal

@happybhati
Copy link
Contributor Author

The dependency update requires the go version to be 1.21. @jinqi7 is taking a look.

note: module requires Go 1.21

I tried with go 1.21. But there are some conflicts between the new version of release-service and devfile library. It perhaps need to communicate with has team.

github.com/devfile/library/v2/pkg/devfile/generator /home/admin/go1.21/gopath/pkg/mod/github.com/devfile/library/v2@v2.2.1-0.20230418160146-e75481b7eebd/pkg/devfile/generator/utils.go:600:14: cannot use corev1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal

Thanks @jinqi7, FYI I shared the issue with HAS team and they are looking into this this: Slack Thread

Meanwhile, adding @flacatus and @psturc they must have some experience with the situation and upgrading to Go 1.21
Since they did the upgrade last time as per David suggestion.

@psturc
Copy link
Collaborator

psturc commented May 13, 2024

@happybhati if go v1.21 is required, we also need to update the test runner image to a newer version here. I can take a look at it tomorrow

@happybhati
Copy link
Contributor Author

@happybhati if go v1.21 is required, we also need to update the test runner image to a newer version here. I can take a look at it tomorrow

Oh okay, Thanks a lot @psturc 👍🏻

@psturc
Copy link
Collaborator

psturc commented May 14, 2024

@happybhati
Copy link
Contributor Author

/retest

@happybhati
Copy link
Contributor Author

@psturc, thanks for the changes. I am not sure why checks still failing :(
Could you please help with it? Thanks.

@psturc
Copy link
Collaborator

psturc commented May 15, 2024

@happybhati it's failing, because it still can't compile

I guess some dependencies need to be updated to workaround the error?

@happybhati happybhati force-pushed the release-230 branch 3 times, most recently from 2ebda7d to 2adacd4 Compare May 15, 2024 14:26
 This commit updates the `release-service` reference
 as result of migration to `konflux-ci` from `redhat-appstudio`
 GitHub org, more details parent EPIC:
 https://issues.redhat.com/browse/RHTAPREL-800

Signed-off-by: Happy Bhati <hbhati@redhat.com>
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@happybhati
Copy link
Contributor Author

HAS team is working on the issue devfile/api#1543

It appears to be a k8s API change in v1.29 that is breaking pkg/devfile/generator/utils.go#L600 in the devfile/library.

Once this issue is resolved, we will be unblocked.

Copy link

openshift-ci bot commented May 15, 2024

🚨 Error occurred during the cluster's Bootstrapping phase, list of failed Spec(s):

  • ➡️ [failed] redhat-appstudio-e2e

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 3480ed3 feat(RELEASE-230): update release service ref to konflux ci org
./mage -v ci:teste2e
# github.com/konflux-ci/release-service/tekton/utils
/go/pkg/mod/github.com/konflux-ci/release-service@v0.0.0-20240514150425-d25d533f66ba/tekton/utils/pipeline_run_builder.go:260:23: undefined: corev1.VolumeResourceRequirements
Error: error compiling magefiles
make: *** [Makefile:25: ci/test/e2e] Error 1


@happybhati: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 3480ed3 link true /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants