feat(STONEBLD-2371): Multi platform controller tests #1134
Conversation
stuartwdouglas
force-pushed
the
STONEBLD-2371
branch
from
302799b
to
b889638
Compare
stuartwdouglas
changed the title
stuartwdouglas
force-pushed
the
STONEBLD-2371
branch
4 times, most recently
from
10f2e51
to
ed7235a
Compare
|
@psturc Can you have a look at this one please, and the associated PRs? It would be good to be able to get tests running on the multi platform controller repo. |
There was a problem hiding this comment.
@stuartwdouglas lot of deprecated tests were removed from this repo, so please also rebase and then we can rerun the rehearsal, thank you!
| @@ -485,6 +485,9 @@ func setRequiredEnvVars() error { | |||
| envVarPrefix = "MULTI_PLATFORM_CONTROLLER" | |||
| imageTagSuffix = "multi-platform-controller" | |||
| testSuiteLabel = "multi-platform" | |||
| im := strings.Split(os.Getenv("OTP_SERVER_IMAGE"), "@") | |||
| os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_REPO", im[0]) | |||
| os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_TAG", im[1]) | |||
There was a problem hiding this comment.
this line needs to change to
if strings.HasSuffix(jobName, "-service-e2e") || strings.Contains(jobName, "controller-e2e") {
otherwise we'll never get to this code block in CI
|
Add in-repo tests for multi platform controller
stuartwdouglas
force-pushed
the
STONEBLD-2371
branch
from
f529322
to
43a01f8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -485,6 +485,9 @@ | |||
| envVarPrefix = "MULTI_PLATFORM_CONTROLLER" | |||
| imageTagSuffix = "multi-platform-controller" | |||
| testSuiteLabel = "multi-platform" | |||
| im := strings.Split(os.Getenv("OTP_SERVER_IMAGE"), "@") | |||
| os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_REPO", im[0]) | |||
| os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_TAG", im[1]) | |||
Check warning
Code scanning / Golang security checks by gosec
Errors unhandled. Warning
| @@ -485,6 +485,9 @@ | |||
| envVarPrefix = "MULTI_PLATFORM_CONTROLLER" | |||
| imageTagSuffix = "multi-platform-controller" | |||
| testSuiteLabel = "multi-platform" | |||
| im := strings.Split(os.Getenv("OTP_SERVER_IMAGE"), "@") | |||
| os.Setenv("MULTI_PLATFORM_CONTROLLER_OTP_IMAGE_REPO", im[0]) | |||
Check warning
Code scanning / Golang security checks by gosec
Errors unhandled. Warning
|
@stuartwdouglas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add in-repo tests for multi platform controller
Description
This is part of a set of changes that should allow the multi platform controller to be tested in-repo.
Additional PRs are:
redhat-appstudio/infra-deployments#3619
openshift/release#51236
Issue ticket number and link
https://issues.redhat.com/browse/STONEBLD-2371