Add a test repo #972
Add a test repo #972
Conversation
KFLUXBUGS-1256 This test repo has a file whose name includes nonlatin characters. Signed-off-by: Chenxiong Qi <cqi@redhat.com>
|
| @@ -38,7 +38,7 @@ spec: | |||
| - name: APP_SUFFIX | |||
| value: "$(params.app_suffix)" | |||
| - name: COMPONENT_REPO_URLS | |||
| value: "https://github.com/redhat-appstudio-qe/devfile-sample-python-basic,https://github.com/redhat-appstudio-qe/retrodep,https://github.com/cachito-testing/pip-e2e-test,https://github.com/redhat-appstudio-qe/fbc-sample-repo,https://github.com/redhat-appstudio-qe/nodejs-no-dockerfile,https://github.com/redhat-appstudio-qe/maven-hello-world,https://github.com/redhat-appstudio-qe/source-build-parent-image-with-digest-only,https://github.com/redhat-appstudio-qe/source-build-parent-image-with-both-tag-digest,https://github.com/redhat-appstudio-qe/source-build-use-latest-parent-image,https://github.com/redhat-appstudio-qe/source-build-parent-image-from-registry-rh-io" | |||
| value: "https://github.com/redhat-appstudio-qe/devfile-sample-python-basic,https://github.com/redhat-appstudio-qe/retrodep,https://github.com/cachito-testing/pip-e2e-test,https://github.com/redhat-appstudio-qe/fbc-sample-repo,https://github.com/redhat-appstudio-qe/nodejs-no-dockerfile,https://github.com/redhat-appstudio-qe/maven-hello-world,https://github.com/redhat-appstudio-qe/source-build-parent-image-with-digest-only,https://github.com/redhat-appstudio-qe/source-build-parent-image-with-both-tag-digest,https://github.com/redhat-appstudio-qe/source-build-use-latest-parent-image,https://github.com/redhat-appstudio-qe/source-build-parent-image-from-registry-rh-io,https://github.com/redhat-appstudio-qe/source-build-nonlatin-chars-in-filenames" | |||
There was a problem hiding this comment.
wondering unit test is sufficient for this type of test or we should add a e2e-test for that? adding a e2e-test mean it will add up in the CI execution time.
There was a problem hiding this comment.
@tisutisu Since the change made in source build has been merged, I think we can reuse an existing test repo by committing such a file instead.
There was a problem hiding this comment.
thanks.. sounds good to me.. it would reduce the overall execution time of the tests
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
KFLUXBUGS-1256
This test repo has a file whose name includes nonlatin characters.
This is for update redhat-appstudio/build-tasks-dockerfiles#76, which needs to be merged in advance.