Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image digest instead of commit tag in order to have renovate updates #810

Closed
wants to merge 1 commit into from

Conversation

mmorhun
Copy link
Collaborator

@mmorhun mmorhun commented Feb 14, 2024

No description provided.

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@@ -18,7 +18,7 @@ spec:
type: string
steps:
- name: e2e-test
image: quay.io/redhat-appstudio/e2e-tests:42f4d88c5decbb098dbea2937aef111f48585252
image: quay.io/redhat-appstudio/e2e-tests@sha256:90d6e83c272d1a75827f9789e1670c2de635a2f3850386c35f8fae28db1f5ccc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We somehow do get updates for these 🤔 #809

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be breaking the e2e-tests update pipeline here?

@lcarva
Copy link
Contributor

lcarva commented Feb 14, 2024

Use image digest instead of commit tag in order to have renovate updates

To be clear, removing the tag means renovate will assume the tag latest. Not sure if those repos do use that tag.

Copy link
Contributor

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the earlier comment, and we use latest for JVM build service. I think think we currently have a way to produce this tag without adding a new pipeline run.

@mmorhun mmorhun closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants